Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=946856 Rahul Sundaram <metherid@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |metherid@xxxxxxxxx --- Comment #1 from Rahul Sundaram <metherid@xxxxxxxxx> --- I am not a sponsor but I will help out with package review. Patches need comments https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment Exclusive arch needs a comment explaining why Provides seems redundant Do list files in %files explicitly and changelog is mandatory run rpmlint on the srpm and binary builds -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cpEUf7U0CC&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review