Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=928061 --- Comment #4 from Antonio Trande <anto.trande@xxxxxxxxx> --- (In reply to comment #3) > Hi Antonio, many thanks for reviews. > > > - "Your package should own all of the files that are installed as part of > > the %install process." > > http://fedoraproject.org/wiki/Packaging: > > Guidelines#File_and_Directory_Ownership > > > > '%{python_sitelib}/Nagstamon' directory must be own of the package. > > > > - " The package must be consistent. For any given path, within the same > > spec, use either a hard-coded path or a macro, not a combination of the two. > > " > > https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/ > > Guidelines#macros > > > > I think you can uniform better %{name} macro. > > %{python_sitelib}/Nagstamon is own of the package: > > wget -O - > http://sourceforge.net/projects/nagstamon/files/nagstamon/nagstamon%200.9.9/ > nagstamon_0.9.9.tar.gz | tar -xzvf - > ... > Nagstamon/Nagstamon/Server/Multisite.py > Nagstamon/Nagstamon/Server/Generic.py > Nagstamon/Nagstamon/resources/ > ... > Package name is 'nagstamon' (first letter is lowercase) but direcotry name > is 'Nagstamon' (first letter is uppercase) so I can't use %{name} macro in > %{install} section. What would be the best - change package name to > Nagstamon and use %{name} macro in %{install} section or use hard-coded path? By using it where you can; for instance: %{_bindir}/nagstamon --> %{_bindir}/%{name} In some case (not in this case because there are not many directories to handle), you can define a submacro with %global or %define (http://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define). See https://docs.fedoraproject.org/en-US/Fedora_Draft_Documentation/0.1/html/RPM_Guide/ch09s07s03.html -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=aBDwKKYAM9&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review