Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=928061 --- Comment #3 from Nikita Klimov <nk@xxxxxxx> --- Hi Antonio, many thanks for reviews. > - Source contains code released with GPLv2+ licensing; LICENSE file is a > GPLv2; 'Nagstamon/Server/Multisite.py' file says: > >...you can redistribute it and/or modify it > ># under the terms of the GNU General Public License as published by > ># the Free Software Foundation in version 2. ... > > 'nagstamon' should be released with GPLv2+ licensing. I will correct License tag and I will be more careful in the future. > > - I think it's sufficient: > > %install > %{__python} setup.py install --skip-build --root %{buildroot} > I will correct it too. > - In my opinion, after %install section all tasks need a short comment that > explains why they are necessary. > > For instance: > > ## Fix 'non-executable-script' error > chmod +x %{buildroot}%{python_sitelib}/Nagstamon/Server/Multisite.py > I'm fully agree. > - "Your package should own all of the files that are installed as part of > the %install process." > http://fedoraproject.org/wiki/Packaging: > Guidelines#File_and_Directory_Ownership > > '%{python_sitelib}/Nagstamon' directory must be own of the package. > > - " The package must be consistent. For any given path, within the same > spec, use either a hard-coded path or a macro, not a combination of the two. > " > https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/ > Guidelines#macros > > I think you can uniform better %{name} macro. %{python_sitelib}/Nagstamon is own of the package: wget -O - http://sourceforge.net/projects/nagstamon/files/nagstamon/nagstamon%200.9.9/nagstamon_0.9.9.tar.gz | tar -xzvf - ... Nagstamon/Nagstamon/Server/Multisite.py Nagstamon/Nagstamon/Server/Generic.py Nagstamon/Nagstamon/resources/ ... Package name is 'nagstamon' (first letter is lowercase) but direcotry name is 'Nagstamon' (first letter is uppercase) so I can't use %{name} macro in %{install} section. What would be the best - change package name to Nagstamon and use %{name} macro in %{install} section or use hard-coded path? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=u5KEq3YB8o&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review