Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=923564 --- Comment #12 from Dan Fruehauf <malkodan@xxxxxxxxx> --- (In reply to comment #11) > Hi Dan > > - not built in rawhide, g_type_init is deprecated in glib 2.35.4, the latest > release in rawhide is glib2-2.36.0-1.fc20, please patch this, adding a > conditional to built correctly > > nm-ssh-service.c:1552:2: error: 'g_type_init' is deprecated (declared at > /usr/in > clude/glib-2.0/gobject/gtype.h:669) [-Werror=deprecated-declarations] > g_type_init (); > ^ > cc1: all warnings being treated as errors > make[2]: *** [nm-ssh-service.o] Error 1 > make[2]: Leaving directory > `/builddir/build/BUILD/NetworkManager-ssh-e27a6ae109f > 0c1f715ee7bf6ae5abd8aff8c7480/src' > make[1]: *** [all-recursive] Error 1 > make[1]: Leaving directory > `/builddir/build/BUILD/NetworkManager-ssh- > e27a6ae109f0c1f715ee7bf6ae5abd8aff8c7480' > make: *** [all] Error 2 > Fixed (guarding with an #ifdef around g_type_init()) Generally speaking, any Rawhide compiling machines I can use? > - I had not seen this carefully > %{_datadir}/gnome-vpn-properties/ssh/nm-ssh-dialog.ui > %dir %{_datadir}/gnome-vpn-properties/ssh > this must be > %dir %{_datadir}/gnome-vpn-properties/ssh > %{_datadir}/gnome-vpn-properties/ssh/nm-ssh-dialog.ui > Fixed (it was the order, yes?) > -rpmlint output > > Rpmlint > ------- > Checking: NetworkManager-ssh-0.0.3-0.3.20130326gite27a6ae.fc18.x86_64.rpm > NetworkManager-ssh.x86_64: W: spelling-error %description -l en_US > capabilites -> capabilities, capability, liabilities Fixed the typo. > NetworkManager-ssh.x86_64: W: incoherent-version-in-changelog > 0.0.3-0.3.20130326git7549f1db1b ['0.0.3-0.3.20130326gite27a6ae.fc18', > '0.0.3-0.3.20130326gite27a6ae'] > > Please double-check the changelog > > NetworkManager-ssh.x86_64: W: non-conffile-in-etc > /etc/dbus-1/system.d/nm-ssh-service.conf > This should be marked as %config, probably, %config(noreplace) > Fixed. > NetworkManager-ssh.x86_64: W: non-conffile-in-etc > /etc/NetworkManager/VPN/nm-ssh-service.name > This should be marked as %config, probably, %config(noreplace) > 1 packages and 0 specfiles checked; 0 errors, 4 warnings. > Fixed. [dan@ugi fedora-rpms]$ rpmlint /home/dan/rpmbuild/RPMS/x86_64/NetworkManager-ssh-0.0.3-0.4.20130328git1af74fd.fc18.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. > - You provide this patch > %{_datadir}/gnome-vpn-properties/ssh, Which patch? > > echevemaster@echevemaster ~$ rpm -qf /usr/share/gnome-vpn-properties/ > nm-connection-editor-0.9.8.0-1.fc18.x86_64 > > but %{_datadir}/gnome-vpn-properties > is ownership (only f18) of nm-connection-editor, in previous releases is of > NetworkManager-gnome, add the following conditional > > %if 0%{?fedora} > 17 > Requires: nm-connection-editor > %else > Requires: NetworkManager-gnome > %endif Fixed. A bit of a confusion about the changelog in the spec. Say I have revision X which is last for the changelog, however revision Y, which is newer is the version I want to build, if I build revision Y and the last entry is revision X, rpmlint complains about it. Hence I assume that in the changelog, the last entry should be of the commit I currently build (which doesn't make any sense, because it's not the last commit the spec was changed), correct me if I'm wrong. So I've included an entry of: '* Thu Mar 28 2013 Dan Fruehauf <malkodan@xxxxxxxxx> - 0.0.3-0.4.%{checkout}' Any other entry will result in a rpmlint yielding an error. Please clarify that issue for me. Speaking of which, if you've found so many errors here, are you aware of the status of NetworkManager and all of the rest of its plugins? Spec URL: http://nm-ssh.cloudapp.net/NetworkManager-ssh.spec SRPM URL: http://nm-ssh.cloudapp.net/NetworkManager-ssh-0.0.3-0.4.20130328git1af74fd.fc18.src.rpm Thanks, Dan. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EzznXLkZUW&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review