[Bug 923564] Review Request: NetworkManager-ssh - NetworkManager VPN plugin for SSH

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=923564

--- Comment #11 from Eduardo Echeverria <echevemaster@xxxxxxxxx> ---
Hi Dan

- not built in rawhide, g_type_init is deprecated in glib 2.35.4, the latest
release in rawhide is glib2-2.36.0-1.fc20, please patch this, adding a
conditional to built correctly

nm-ssh-service.c:1552:2: error: 'g_type_init' is deprecated (declared at
/usr/in
clude/glib-2.0/gobject/gtype.h:669) [-Werror=deprecated-declarations]
  g_type_init ();
  ^
cc1: all warnings being treated as errors
make[2]: *** [nm-ssh-service.o] Error 1
make[2]: Leaving directory
`/builddir/build/BUILD/NetworkManager-ssh-e27a6ae109f
0c1f715ee7bf6ae5abd8aff8c7480/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory
`/builddir/build/BUILD/NetworkManager-ssh-e27a6ae109f0c1f715ee7bf6ae5abd8aff8c7480'
make: *** [all] Error 2

- I had not seen this carefully
%{_datadir}/gnome-vpn-properties/ssh/nm-ssh-dialog.ui
%dir %{_datadir}/gnome-vpn-properties/ssh
this must be 
%dir %{_datadir}/gnome-vpn-properties/ssh
%{_datadir}/gnome-vpn-properties/ssh/nm-ssh-dialog.ui

-rpmlint output

Rpmlint
-------
Checking: NetworkManager-ssh-0.0.3-0.3.20130326gite27a6ae.fc18.x86_64.rpm
NetworkManager-ssh.x86_64: W: spelling-error %description -l en_US capabilites
-> capabilities, capability, liabilities
NetworkManager-ssh.x86_64: W: incoherent-version-in-changelog
0.0.3-0.3.20130326git7549f1db1b ['0.0.3-0.3.20130326gite27a6ae.fc18',
'0.0.3-0.3.20130326gite27a6ae']

Please double-check the changelog

NetworkManager-ssh.x86_64: W: non-conffile-in-etc
/etc/dbus-1/system.d/nm-ssh-service.conf
This should be marked as %config, probably,  %config(noreplace)

NetworkManager-ssh.x86_64: W: non-conffile-in-etc
/etc/NetworkManager/VPN/nm-ssh-service.name
This should be marked as %config, probably,  %config(noreplace)
1 packages and 0 specfiles checked; 0 errors, 4 warnings.

- You provide this patch 
%{_datadir}/gnome-vpn-properties/ssh,

echevemaster@echevemaster ~$ rpm -qf /usr/share/gnome-vpn-properties/
nm-connection-editor-0.9.8.0-1.fc18.x86_64

but %{_datadir}/gnome-vpn-properties
is ownership (only f18) of nm-connection-editor, in previous releases is of
NetworkManager-gnome, add the following conditional 

%if 0%{?fedora} > 17
Requires: nm-connection-editor
%else
Requires: NetworkManager-gnome
%endif

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Uk0QNTXNNn&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]