Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=926763 Kevin Fenzi <kevin@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #4 from Kevin Fenzi <kevin@xxxxxxxxx> --- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (BSD) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 2d85cf6aa3c40455846e534d12e18e6e06c628d4876d7758e46f707c336acb46 TracAuthOpenId-0.4.2.tar.gz 2d85cf6aa3c40455846e534d12e18e6e06c628d4876d7758e46f707c336acb46 TracAuthOpenId-0.4.2.tar.gz.orig OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have sane scriptlets. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. Minor nitpick: "This plugin allows to login to Trac using OpenID." reads oddly, perhaps: "This plugin allows users to login to Trac using OpenID." 2. rpmlint says: trac-authopenid-plugin.noarch: W: spelling-error %description -l en_US login -> loin, logic, lo gin trac-authopenid-plugin.src: W: spelling-error %description -l en_US login -> loin, logic, lo gin 2 packages and 0 specfiles checked; 0 errors, 2 warnings. can be ignored. I don't see any blockers here, so this package is APPROVED. Happy to co-maintain. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=02sDeqmZaE&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review