Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=871197 Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: catkin - |Review Request: catkin - |Official build system of |Collection of CMake macros |ROS |for ROS --- Comment #8 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- Errors have been corrected. rpmlint: [ankur@dhcppc1 SRPMS]$ rpmlint ../SPECS/catkin.spec ./catkin-0.4.5-5.gitd4f1f24.fc18.src.rpm /var/lib/mock/fedora-rawhide-x86_64/result/*.rpm ../SPECS/catkin.spec: W: invalid-url Source0: ros-catkin-0.4.5-0-gd4f1f24.tar.gz catkin.src: W: invalid-url Source0: ros-catkin-0.4.5-0-gd4f1f24.tar.gz catkin.noarch: W: no-manual-page-for-binary catkin_install_parse catkin.noarch: W: no-manual-page-for-binary git-catkin catkin.noarch: W: no-manual-page-for-binary git-catkin-track-all catkin.noarch: W: no-manual-page-for-binary catkin-version catkin.noarch: W: no-manual-page-for-binary catkin-parse-stack catkin.noarch: W: no-manual-page-for-binary catkin-bump-version catkin.noarch: W: no-manual-page-for-binary catkin-build-debs-of-workspace catkin.noarch: W: no-manual-page-for-binary catkin-topological-order catkin.src: W: invalid-url Source0: ros-catkin-0.4.5-0-gd4f1f24.tar.gz catkin-devel.noarch: W: no-documentation catkin-devel.noarch: E: non-executable-script /usr/share/catkin/cmake/templates/setup.sh.installable.in 0644L /bin/sh catkin-devel.noarch: E: non-executable-script /usr/share/catkin/cmake/templates/setup.sh.installable.in.etc 0644L /bin/sh catkin-devel.noarch: E: non-executable-script /usr/share/catkin/cmake/templates/setup.zsh.installable.in 0644L /bin/zsh catkin-devel.noarch: E: non-executable-script /usr/share/catkin/cmake/templates/setup.bash.installable.in 0644L /bin/bash catkin-devel.noarch: E: non-executable-script /usr/share/catkin/cmake/templates/setup.bash.buildspace.in 0644L /bin/bash catkin-devel.noarch: E: non-executable-script /usr/share/catkin/cmake/templates/update_project_index.py.in 0644L /usr/bin/env catkin-devel.noarch: E: non-executable-script /usr/share/catkin/cmake/templates/setup.sh.buildspace.in 0644L /bin/sh catkin-devel.noarch: E: non-executable-script /usr/share/catkin/cmake/templates/setup.zsh.buildspace.in 0644L /bin/zsh catkin-devel.noarch: E: non-executable-script /usr/share/catkin/cmake/interrogate_setup_dot_py.py 0644L /usr/bin/env 4 packages and 1 specfiles checked; 9 errors, 12 warnings. [ankur@dhcppc1 SRPMS]$ The *.in files are okay I guess. Although, the templates would've been better without shebangs. What about the one py file? :/ That's all I can find. The rest looks okay. I can't quite figure out what this one py file does. Does it need to have the shebang? I checked up. Py files in /usr/share have their shebangs removed. Thanks, Warm regards, Ankur -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1PkAGqk4sI&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review