[Bug 923564] Review Request: NetworkManager-ssh - NetworkManager VPN plugin for SSH

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=923564

--- Comment #8 from Dan Fruehauf <malkodan@xxxxxxxxx> ---
Hi Eduardo,

Seems almost like I manage to get one step forward and three steps back :)

 - Fixed changelog in spec file, including only changes to spec (packaging
wise)

 - Building RPM with .gz and not .xz
   - Verified the github URL is valid
(https://github.com/danfruehauf/NetworkManager-ssh/archive/8767415030da697a1a08cb536166c0ca7bb037b2/NetworkManager-ssh-0.0.3-8767415.tar.gz)

 - Remove scriptlets
   - If there's nothing in %post and $postun, should the sections exist anyway?

 - %{checkout} is defined by hand and conforming what I could understand in the
URL you've provided

 - I've changed the %{checkout} tag to conform the standards, although it's not
100% clear. An example in that file would make things heaps clearer...
   - What is exactly %{alphatag}? Is it defined at all? %{X}?
   - Currently I have 'Release: 2.%{checkout}%{?dist}'
   - Release (2, or %{X}) is separated by a comma from %{checkout}
   - %{checkout} is 20130322git%{shortcommit} - much like '20110102git9e88d7e'
in the URL

 - But I'm not using epoch anyway anymore anywhere! No versioned dependencies

I've posted a new .spec and SRPM:
Spec URL: http://nm-ssh.cloudapp.net/NetworkManager-ssh.spec
SRPM URL:
http://nm-ssh.cloudapp.net/NetworkManager-ssh-0.0.3-2.20130322git8767415.fc18.src.rpm

I really hope we're making some sort of progress, I'm really trying my best as
you can see... :)
Many thanks,
Dan.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pvjudxU81j&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]