Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=923564 --- Comment #7 from Eduardo Echeverria <echevemaster@xxxxxxxxx> --- Hi again Dan I go back on my words, the changelog is not related to the code changes of the application, is related with the changes in the spec, by example, a good changelog would look like this * Wed Mar 20 2013 Dan Fruehauf <malkodan@xxxxxxxxx> - 0.0.0-2 - Added COPYING file - Removed ChangeLog file from RPM package as a full changelog is in the spec * Wed Mar 20 2013 Dan Fruehauf <malkodan@xxxxxxxxx> - 0.0.0-1 - Initial packaging Remember bump the release number, every time you make a change to spec. As you can see only in the changelog, only there entries about the modifications made to spec - Afaik, Github not generate xz files, only zip or tar.gz. https://github.com/danfruehauf/NetworkManager-ssh/archive/cf6c00f117a761c8b0e88462c84e99df58c4a352/NetworkManager-ssh-0.0.3-cf6c00f.tar.xz gives an error 404 not so: https://github.com/danfruehauf/NetworkManager-ssh/archive/cf6c00f117a761c8b0e88462c84e99df58c4a352/NetworkManager-ssh-0.0.3-cf6c00f.tar.gz or https://github.com/danfruehauf/NetworkManager-ssh/archive/cf6c00f117a761c8b0e88462c84e99df58c4a352/NetworkManager-ssh-0.0.3-cf6c00f.zip you should also download the file, preserving the timestamps, with the command wget -N or curl -R. see http://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps this scriptlets: %post /usr/bin/update-desktop-database > /dev/null touch --no-create %{_datadir}/icons/hicolor if [ -x /usr/bin/gtk-update-icon-cache ]; then /usr/bin/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || : fi %postun /usr/bin/update-desktop-database > /dev/null touch --no-create %{_datadir}/icons/hicolor if [ -x /usr/bin/gtk-update-icon-cache ]; then /usr/bin/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || : fi not needed, no there .desktop files or icons listed in your spec, equally is applicable to Requires, for the same reason Requires(post): %{_bindir}/update-desktop-database Requires(postun): %{_bindir}/update-desktop-database - Please the date of the snapshot should be placed by hand - the naming is incorrect, in the case of pre-release package you should follow this guidelines http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_packages - Please, remember my comment in the case of NetworkManager-devel, or any package that makes use of epoch (In reply to comment #5) > Oh, i'm sorry, i had a copy n' paste error (in the case of > NetworkManager-devel) , this not applied to the dependent packages with > epoch, which must be declared anywhere as %{epoch}:%{version}-%{release} See http://fedoraproject.org/wiki/Packaging:Guidelines#Use_of_Epochs I quote: "Also, Epoch complicates normal packaging guidelines. If a package uses an Epoch, it must be referred to in any place where %{version}-%{release} is used. For example, if a package being depended upon has an Epoch, this must be listed when adding a versioned dependency: Requires: foo = %{epoch}:%{version}-%{release}. " Cheers -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kNf9HsLHiL&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review