Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=923564 --- Comment #4 from Eduardo Echeverria <echevemaster@xxxxxxxxx> --- Hi (In reply to comment #3) I'm generating the Changelog dynamically from github commits, is that OK? No, the changelog are related to the spec not to the code changes, see https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs, please place the changelog by hand %define snapshot ___snapshot___ %define realversion ___version___ Version: ___version___ Release: 1%{snapshot}%{?dist} and equally either the snapshot or version must be placed by hand, see http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages > - The .spec I've attached is being handled by a make target (make rpm) and > does the following: > - Replaces version in .spec > - Replaces github version (revision) in .spec > - Generates the Changelog Although this is fine for generating rpms on demand, not right for a valid rpm in Fedora repositories - Please add COPYING file, in this moment not listed in %doc - Please, see https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group#Convincing_someone_to_sponsor_you, to search a willing sponsor, especially try doing some informal reviews to other packagers. - Remember check the available versions of gtk3-devel, dbus-devel, NetworkManager-devel, NetworkManager-glib-devel, if the versions are greater than which you define, the declarations >= are not necessary ( Example: echevemaster@echevemaster ~$ repoquery -qf --whatprovides --releasever=18 NetworkManager-devel NetworkManager-devel-1:0.9.7.0-12.git20121004.fc18.i686 NetworkManager-devel-1:0.9.7.0-12.git20121004.fc18.x86_64 NetworkManager-devel-1:0.9.8.0-1.fc18.i686 NetworkManager-devel-1:0.9.8.0-1.fc18.x86_64 NetworkManager-devel-1:0.9.7.0-12.git20121004.fc18.i686 NetworkManager-devel-1:0.9.7.0-12.git20121004.fc18.x86_64 * NetworkManager-devel-1:0.9.8.0-1.fc18.i686 * NetworkManager-devel-1:0.9.8.0-1.fc18.x86_64 in your case the system-wide version is greater than you which you define %define nm_version 1:0.9.2 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2Pz9ekJIQY&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review