Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=923564 Dan Fruehauf <malkodan@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 (FE-NEEDSPONSOR) --- Comment #3 from Dan Fruehauf <malkodan@xxxxxxxxx> --- Hi, First and foremost thank you. I'm happy to be part of Fedora. And thank you for the prompt and detailed response. I'll relate to the points you've mentioned one by one. - Added FE-NEEDSPONSOR - Using now %global instead of %define - Removed Epoch tag - I'll have a look shortly at the guidelines for github projects, I was actually looking for something like that - Added a TODO for myself to remove these lines if they are unnecessary - Changed the install call to what you suggested: make DESTDIR=%{buildroot} INSTALL="install -p" CP="cp -p" install - No .desktop files, it merely installs a NetworkManager plugin - No installing any icons as far as I'm concerned - Removed the %defattr line - I'm generating the Changelog dynamically from github commits, is that OK? - I'm based on the code in NetworkManager-openvpn, however by that time the code is totally different and serves a totally different purpose. There will always be similarity between the various VPN plugins as they implement the same interface, but solves a different problem. - The .spec I've attached is being handled by a make target (make rpm) and does the following: - Replaces version in .spec - Replaces github version (revision) in .spec - Generates the Changelog - I'm pretty sure after I'll read the github guidelines I'll be smarter about all of that. Thanks, Dan. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8oEUdI6wk2&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review