Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919867 --- Comment #7 from Tadej Janež <tadej.janez@xxxxxxxxxxxxxxxxx> --- Hi! (In reply to comment #4) > > Move the files to %{_libdir} is the way to solve this. I've quickly whipped > a version > of the package with this done. I'll attach the modified spec file and the > (small) patch to billiards.in here. Thanks! I've used your modified .spec file and the patch to billiards.in. > Ah, I've never seen anyone do this (use %make_install) I did not know there > is both a %makeinstall and a %make_install, very confusing whomever came > up with that does not get a beer from me the next time I see him. > > I would still prefer if you switched to "make install DESTDIR=%{buildroot}" > since that is much more readable, what our packaging templates use, and > thus what most packages use. But you're free the keep things as is. Ok, I understand your arguments and I've switched to "make install DESTDIR=%{buildroot}". When I saw the this change in Packaging Guidelines I thought it was the new and preferred way to go. (In reply to comment #5) > I just noticed that techne itself contains lc files under /usr/share too, if > those are moved to %{_libdir} too, then I guess that %{_libdir}/techne will > be part of the default search path and this patch won't be needed. Ooh, thanks for catching this. Yes, this way, just Techne would need fixing. (In reply to comment #6) > For techne itself an other possible approach is to not byte-compile the > kolmogorov file as that seems to be the only lc file in there. Yes, this is another possible approach. I'll contact the upstream author and suggest this to him. New spec and SRPM files are here: http://tadej.fedorapeople.org/billiards.spec http://tadej.fedorapeople.org/billiards-0.4.1-3.fc17.src.rpm Thanks and best regards, Tadej -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yq5IhW7pdZ&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review