[Bug 921985] Review Request: rubygem-foreman_api - Ruby bindings for Forman's rest API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=921985

--- Comment #3 from Josef Stribny <jstribny@xxxxxxxxxx> ---
Thanks Miroslav,

before the rubygem-oauth is rebuilt I have two recommendations for the spec
file:

1, %{gem_docdir} could be marked as %doc 
   Since %{gem_docdir} contains only doc files and no executable files, it
should be marked as %doc. From the guidelines [1]: "Any relevant documentation
included in the source distribution should be included in the package as %doc"

2, %{gem_cache} should be excluded
   %{gem_cache} has no purpose in this RPM and should be excluded.

[1] http://fedoraproject.org/wiki/Packaging:Guidelines

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=aewkhxjUMA&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]