Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=919469 --- Comment #11 from Wolfgang Ulbrich <chat-to-me@xxxxxxxxx> --- > Wolfgang, Patrick, > > Thanks for your help on this package. I did not expect it to cause such a > large discussion. > > Let me explain briefly: > > 1. The spec file in my source tarball: in all my sources I always add a spec > file. It is designed to be as generic as possible and will likely fail any > check for compliance with strict distribution rules - like Fedora's. It is > mostly for my usage, because I try to provide generic RPMs whenever feasible > (my software usually has only few dependencies, not hard to track). > > To be able to quickly build RPMs for different architectures (and use > cases), I prefer to build the RPM file in-tree using the Makefile with 'make > rpm'; therefore, my spec files usually have "%setup" and "./configure" > commented out - my usual workflow is to run ./configure wth proper > parameters (even if it is cross-compile), then "make" and "make rpm". I know > that there are (and I have used) dedicetdd tols like mock, but still I find > it easier and quicker to buil RPMs in-tree. This is exactly what i thought. So it makes no sense to patch mate-applet-softupd.spec.in if upstream don't want to follow them. And as i said before, for building the package for fedora this file is useless. > > I can't tell whether Patrick should patch my RPM file or keep an entirely > new one; to me, Fedora seems too cutting-edge in terms of spec files (e.g., > I don't want to lose, in general, the ability to build on/for RHEL - or cut > off things which will work on other RPM-based distros), so I guess it is > better for the package maintainer to decide. > > 2. The patch: when I released 0.2.5, one of the descriptions in French, sent > me by Patrick, was missing. This is fixed in my trunk along with the > configure.ac. I can tag and send you a 0.2.6 tarball right away, if this > will make it easier for you. Otherwise, youcan apply the patch as it is > written by Patrick. > > WWell, Thanks for your comment. For me you shouldn't release a new release now, because it is valid to use the patch without mate-applet-softupd.spec.in, for correct the french translation which is in upstream. @ Patrick You're right with BR automake, don't change this. So pls, update SPEC and SRPM for the final review. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zJVxPps6Yo&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review