Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=916087 --- Comment #11 from Juerg Haefliger <juergh@xxxxxxxxx> --- (In reply to comment #10) > Something's wrong with your F18 then ;) Well that would be Matt's cloud image then since that's what I'm running :-) > %_datadir should always point to > /usr/share. Go with %{_prefix}/lib for Fedora. Got it. > > > (Also, it shouldn't own /usr/lib/dracut and > > > /usr/lib/dracut/modules.d, because dracut already does.) > > > > So I need to use something like the following in the %files section? > > %{_datadir}/dracut/modules.d/* > > Yes. Or, since it's only two files, specify both with the complete path (on > two lines). Yep, makes sense. > I don't think it does suggest that. For example, most perl-* or R-* or <any > language>-* are not subpackages but separate SRPMS. Matt is right though, it > should be dracut-modules-growroot. Why "-growroot" and not "-growpart" (like > the tool that is used), though? If that's an upstream decision, okay. Because the module specifically grows (only) the root partition (using the growpart script from cloud-utils). > Is there any reason it's not called cloud-initramfs-tools, then? If not, > that needs to be fixed. The guideline is rather strict. Ok. I was under the impression that a subpackage always needs to include the name of the parent package which would have resulted in cloud-initramfs-tools-growpart which I though was a rather awkward name :-) Will fix. So do I need to open a new review request since the package names changes? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3e5zxcgx66&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review