Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=916087 --- Comment #10 from Sandro Mathys <sm@xxxxxxxxxxxxxxxx> --- New feedback to the spec file: The Requires _need_ to be *under* the %package line. Right now the Requires count towards the *main* package (which is never built) and the subpackage doesn't have any Requires. (In reply to comment #5) > (In reply to comment #4) > > I notice that this puts everything under /usr/share/dracut. Shouldn't that > > be /usr/lib/dracut? > > Hmm... it's /usr/lib for Fedora 18 and /usr/share for RHEL6. When I built it > locally under Fedora 18 it was correctly using /usr/lib but the koji built > is using /usr/share. What gives? Am I using the wrong macro (%{_datadir})? Something's wrong with your F18 then ;) %_datadir should always point to /usr/share. Go with %{_prefix}/lib for Fedora. > > (Also, it shouldn't own /usr/lib/dracut and > > /usr/lib/dracut/modules.d, because dracut already does.) > > So I need to use something like the following in the %files section? > %{_datadir}/dracut/modules.d/* Yes. Or, since it's only two files, specify both with the complete path (on two lines). (In reply to comment #6) > > Is that submodule useful outside of cloud-init on its own, or does it need other stuff? If the former, yeah, that makes sense. > > It can be used outside of cloud-init but it requires cloud-utils which > provides the growpart script. Not sure how much sense this makes in a > non-cloud image though. It can technically, that's what counts. IMHO :) > Wouldn't a name like dracut-growroot suggest that this is a dracut > subpackage? Note that I'm not strictly following the convention that the > package name should match upstream since upstream is named > cloud-initramfs-tools. I don't think it does suggest that. For example, most perl-* or R-* or <any language>-* are not subpackages but separate SRPMS. Matt is right though, it should be dracut-modules-growroot. Why "-growroot" and not "-growpart" (like the tool that is used), though? If that's an upstream decision, okay. Is there any reason it's not called cloud-initramfs-tools, then? If not, that needs to be fixed. The guideline is rather strict. (In reply to comment #7) > (In reply to comment #1) > > Also, I think an additional /etc/dracut.conf.d/xx-growroot.conf to > > automatically enable inclusion of the module in new initramfs builds would > > make sense. IMHO that's what someone would expect to happen after one > > installed the package. > > I'm not following you. The module does get included on the next initramfs > build since the check() function from module-setup.sh returns 0. Seems to work, so you probably know better how that works than me. Taking my comment back. :) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zTFHJYSbI2&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review