Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=913289 --- Comment #2 from Peter Hanecak <hany@xxxxxxx> --- (In reply to comment #1) > Hi Peter. > Just few comment. > > - There are more licenses in the source: > > $ licensecheck * | grep -v UNKNOWN ... > srgb_profile.h: MIT/X11 (BSD like) ... Based on https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Good_Licenses ("MIT license (also X11)" -> "MIT") I've changed it to "GPLv2+ and MIT". > - Source link not found Fixed with URL to sourceforge.jp . > - [ "%{buildroot}" != / ] && rm -rf "%{buildroot}" > > Why do you use this form ? > > http://fedoraproject.org/wiki/EPEL/ > GuidelinesAndPolicies#Prepping_BuildRoot_For_.25install It was a leftover from the original author of the spec. I've now replaced that with: BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) %install rm -rf %{buildroot} %clean rm -rf %{buildroot} Updated package and spec can be found here: http://hany.sk/~hany/_data/fedoraproject/gimp-separate+.spec http://hany.sk/~hany/_data/fedoraproject/gimp-separate+-0.5.8-2.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jsar3B3wyv&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review