[Bug 913289] Review Request: gimp-separate+ - A plug-in providing rudimentary CMYK support for The GIMP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=913289

Antonio Trande <trpost@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |trpost@xxxxxxxxxxxx

--- Comment #1 from Antonio Trande <trpost@xxxxxxxxxxxx> ---
Hi Peter.
Just few comment.

- There are more licenses in the source:

$ licensecheck * | grep -v UNKNOWN
import.c: GPL (v2 or later) (with incorrect FSF address)
jpeg.c: GPL (v2 or later) (with incorrect FSF address)
jpeg.h: GPL (v2 or later) (with incorrect FSF address)
psd.c: GPL (v2 or later) (with incorrect FSF address)
psd.h: GPL (v2 or later) (with incorrect FSF address)
separate-core.c: GPL (v2 or later) (with incorrect FSF address)
separate-core.h: GPL (v2 or later) (with incorrect FSF address)
separate-export.c: GPL (v2 or later) (with incorrect FSF address)
separate-export.h: GPL (v2 or later) (with incorrect FSF address)
separate-gui.c: GPL (v2 or later) (with incorrect FSF address)
separate.h: GPL (v2 or later) (with incorrect FSF address)
srgb_profile.h: MIT/X11 (BSD like)
tiff.c: GPL (v2 or later) (with incorrect FSF address)
tiff.h: GPL (v2 or later) (with incorrect FSF address)
util.c: GPL (v2 or later) (with incorrect FSF address)
util.h: GPL (v2 or later) (with incorrect FSF address)

I think, needs to indicate even the second:

License:       GPLv2+ and BSD

See:
http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licensing_Scenarios

- Source link not found

- [ "%{buildroot}" != / ] && rm -rf "%{buildroot}"

Why do you use this form ?

http://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#Prepping_BuildRoot_For_.25install

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=QGAhtcdp5g&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]