[Bug 229910] Review Request: Conmux - Console Multiplexor, abstracts how to connect via backend drivers.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: Conmux - Console Multiplexor, abstracts how to connect via backend drivers.


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229910





------- Additional Comments From jwilson@xxxxxxxxxx  2007-02-26 16:14 EST -------
Ugh. The package conserver-client contains a /usr/bin/console also. It was there
first, so gotta do something to prevent the namespace collision. I'd probably
make /usr/sbin/conmux into /usr/sbin/conmuxd and make /usr/bin/console into
/usr/bin/conmux.

Question on the Requires: does the base conmux server portion really *require*
the client to be installed to function? If not, I'd say drop that hard Requires.

A few of the comments should be altered slightly, you have "put in our own
initscript and logrotate", but the first file installed is the config file, not
the initscript. Note that the conf file getting installed mode 0644 there also
eliminates the need for the "adjust perms on main config file" comment and
following line.

Not really sure what to do about the .pm file, I try not to touch or even think
about perl... :)

Also, as you update the package from here out, go ahead and bump the package
version each time, along with corresponding changelog entries illustrating
what's been done -- helps make it clear what's been done when, makes it easier
for reviewers to figure out which revision of the package they've got, etc.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]