Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=885013 Toshio Ernie Kuratomi <a.badger@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |a.badger@xxxxxxxxx Flags| |fedora-review+ --- Comment #8 from Toshio Ernie Kuratomi <a.badger@xxxxxxxxx> --- ef78d0532f11c4403288a6a4a7e80da2f8924e6b0d662349bb86c09c6fea8b31 backports.ssl_match_hostname-3.2a3.tar.gz Good: * package name meets guidelines * spec file name matches package name * license has been approved. Comment to explain the situation * Spec file is legible * Source matches upstream * No locale files * Not an elf library * No bundled system libraries * Not designed to be relocatable * Package owns all directories it creates * Files listed only once * Permissions set properly * Code, not content * No large docs * Nothing in %doc will affect runtime * Not a GUI application * Does not own files or directories owned by another package at this time. See Notes section below. * All filenames are valid UTF-8 * No scriptlets needed * Builds in koji rpmlint * python-backports-ssl_match_hostname.noarch: W: spelling-error Summary(en_US) ssl -> isl, sol, ssh * python-backports-ssl_match_hostname.noarch: W: spelling-error Summary(en_US) hostname -> host name, host-name, hostage * python-backports-ssl_match_hostname.noarch: W: spelling-error %description -l en_US backport -> back port, back-port, backpacker - All spelling wawrnings are acceptable jargon. False positives in this case. Notes: * Ping upstream with the licensing concerns and request that he adds a License files * note, the backports module seems to be setup as a namespace module. In the future, there may be other packages that attempt to install here. RPM should be able to gracefully handle the directory itself and the __init__.py file should this happen. However, it will not be able to handle the .pyc and .pyo files as those contain timestamps. Should other packages be released by upstream that use the backports module namespace, I recommend shipping a separate python-backports package with the things necessary for the namespace ( %{python_sitelib}/backports and %{python_sitelib}/backports/__init__.py* ) then having all modules within this namespace require it. APPROVED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XGnH6dwJ6p&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review