Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=812526 --- Comment #5 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- naming: ok sources: NOT ok. 2. package MUST use verifiable sources. srpm source md5sum: 19ff232d654d5497c9dabe4d7f159946 kolab-webadmin-3.0.3.tar.gz Source0 URL md5sum: 9246c9844036141e21096361147eceac kolab-webadmin-3.0.3.tar.gz license: ok macros: ok scriptlets: ok but... I assume this is from legacy stuff to cleanup after older packaging? if [ $1 -gt 1 ]; then if [ ! -L "/usr/share/kolab-webadmin/hosted/js" ... rm -rf /usr/share/kolab-webadmin/hosted/js >/dev/null 2>&1 || : fi ... fi 3. whatever it's purpose, you SHOULD document with a comment what it's for exactly. and maybe even consider removing or conditionalizing it for rhel only (ie, since none of these packages have been published for fedora, they are likely not needed). otherwise, relatively simple web app here, please clarify points 1-3 for me. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=geBTrjPvkQ&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review