Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904658 --- Comment #8 from Brendan Jones <brendan.jones.it@xxxxxxxxx> --- (In reply to comment #7) > Some notes: > > * Optimization level > - For changing optimization level, please add some comments on > your spec file about the discussion on this review request > (especially the comments / explanation from Kjetil) > for justification. Good call - will do. > > ! Honoring Fedora specific compilation flags > - Well, it seems somewhat strange that you have to use sed for Makefile > and also change "OPTS" variables to honor Fedora specific compilation > flags, however not a blocker. > I think this is a feature in the build script. I'll send a patch upstream. Thanks for the review! -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wruJtk04dE&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review