Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904658 Mamoru TASAKA <mtasaka@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #7 from Mamoru TASAKA <mtasaka@xxxxxxxxxxxxxxxxx> --- Some notes: * Optimization level - For changing optimization level, please add some comments on your spec file about the discussion on this review request (especially the comments / explanation from Kjetil) for justification. ! Honoring Fedora specific compilation flags - Well, it seems somewhat strange that you have to use sed for Makefile and also change "OPTS" variables to honor Fedora specific compilation flags, however not a blocker. ------------------------------------------------------------- This package (radium-compressor) is APPROVED by mtasaka ------------------------------------------------------------- -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Xyxl1hmIF7&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review