Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Chmsee - a GTK2 CHM viewer based on chmlib and gecko https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229826 bbbush.yuan@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: <Chmsee> - |Review Request: Chmsee - a |<a GTK2 CHM viewer based on |GTK2 CHM viewer based on |chmlib and gecko> |chmlib and gecko ------- Additional Comments From bbbush.yuan@xxxxxxxxx 2007-02-25 00:35 EST ------- (In reply to comment #7) > Issues: > > * the openssl-devel buildrequires is a bit weird. Where does it > comes from? > chmsee works by extracting all files. Openssl is used to calculate md5 from filename. The md5sum will be used as a directory name, to hold files extracted from different CHM files. > * In general it is not usefull to have the package name in > the summary, all the tools should already show it > removed for default "Summary". rpmlint complains about "Summary not capitalized" for Summary(zh_CN) if there is no Capitalized "ChmSee". > * desktop-file-utils shared-mime-info should not be in Requires(pre) > Requires(post) as explained on the past scripts snippets page > removed. I thought they should be there but I haven't read those guidelines for a long time. > * However desktop-file-utils should be a BuildRequires. > thanks. > * --vendor should be fedora and not gnome. > changed. > * --add-category Utility seems to be unusefull to me since it is already > in the desktop file. > removed. > > Suggestions: > > * I suggest removing Application category in the patch and not on the > command line > > * I suggest calling the patch along > chmsee-1.0.0-desktop-mimetype.patch > renamed. > * I suggest putting the chmsee-icon.png in > /usr/share/icons/hicolor/48x48/apps > call it chmsee.png and adapt the desktop file accordingly. > done. > * snippet for icon theme update should be used (for gnome > theme instead of hicolor, or both if you follow my suggestion > above), see: > done. The app icon was in pixmaps directory so this was not needed. Moving it to hicolor seems to be a good idea. > > * %description is a bit terse, especially compared with the zh_CN > one. > check it :) Spec URL: ftp://ftp.fedora.cn/pub/fedora-cn/in-review/chmsee.spec SRPM URL: ftp://ftp.fedora.cn/pub/fedora-cn/in-review/chmsee-1.0.0-0.6.beta.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review