Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: <Chmsee> - <a GTK2 CHM viewer based on chmlib and gecko> https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229826 ------- Additional Comments From pertusus@xxxxxxx 2007-02-24 10:53 EST ------- Issues: * the openssl-devel buildrequires is a bit weird. Where does it comes from? * In general it is not usefull to have the package name in the summary, all the tools should already show it * desktop-file-utils shared-mime-info should not be in Requires(pre) Requires(post) as explained on the past scripts snippets page * However desktop-file-utils should be a BuildRequires. * --vendor should be fedora and not gnome. * --add-category Utility seems to be unusefull to me since it is already in the desktop file. Suggestions: * I suggest removing Application category in the patch and not on the command line * I suggest calling the patch along chmsee-1.0.0-desktop-mimetype.patch * I suggest putting the chmsee-icon.png in /usr/share/icons/hicolor/48x48/apps call it chmsee.png and adapt the desktop file accordingly. * snippet for icon theme update should be used (for gnome theme instead of hicolor, or both if you follow my suggestion above), see: http://fedoraproject.org/wiki/Packaging/ScriptletSnippets?action=show&redirect=ScriptletSnippets#head-7103f6c38d1b5735e8477bdd569ad73ea2c49bda * %description is a bit terse, especially compared with the zh_CN one. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review