Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901419 Mathieu Bridon <bochecha@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends On| |907309 --- Comment #5 from Mathieu Bridon <bochecha@xxxxxxxxxxxxxxxxx> --- (In reply to comment #4) > Ok, so I've looked at your new package and have some "bad news" for you :) > > You're missing a BR, perl(Exporter) -- this is pulled in through "use base" > on lib/Lingua/Identify.pm:8. Added. > On the other hand, you don't have to list the dependencies of the > make-lingua-identify-language (perl(locale) and perl(POSIX)) as it's not > tested, even though upstream probably wanted to (given the fourth test > filename). > I've created a ticket for it, RT#83071 [1]. Thanks, I had completely missed that. > You can also just patch the test and keep your deps in place. If you decide > to do this instead, also add perl(Text::ExtractWords) to your list. Unfortunately, Text::ExtractWords is not in Fedora. :( https://bugzilla.redhat.com/show_bug.cgi?id=907309 --- Spec URL: http://bochecha.fedorapeople.org/packages/perl-Lingua-Identify.spec SRPM URL: http://bochecha.fedorapeople.org/packages/perl-Lingua-Identify-0.51-3.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=41nvzuc5cC&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review