[Bug 901419] Review Request: perl-Lingua-Identify - Language identification

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=901419

--- Comment #4 from Petr Šabata <psabata@xxxxxxxxxx> ---
Ok, so I've looked at your new package and have some "bad news" for you :)

You're missing a BR, perl(Exporter) -- this is pulled in through "use base" on
lib/Lingua/Identify.pm:8.

On the other hand, you don't have to list the dependencies of the
make-lingua-identify-language (perl(locale) and perl(POSIX)) as it's not
tested, even though upstream probably wanted to (given the fourth test
filename).
I've created a ticket for it, RT#83071 [1].
You can also just patch the test and keep your deps in place.  If you decide to
do this instead, also add perl(Text::ExtractWords) to your list.

[1] https://rt.cpan.org/Public/Bug/Display.html?id=83071

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bnpppZZp1W&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]