Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906362 --- Comment #3 from Darryl L. Pierce <dpierce@xxxxxxxxxx> --- (In reply to comment #2) > I don't see the perl bindings listed on http://qpid.apache.org/proton/ and > your Source isn't a URL. Where does this come from? There's no explanation > in the spec file... > > You're also missing the following build-deps: > perl(Test::Exception) > perl(Test::More) Fixed that, thanks. > Your changelog entry references version 0.03 instead of 0.3. Ugh. Muscle memory from packaging Qpid as well. Fixed. > Tip: Substitute command macros (like %{__perl}) with simple calls (lines 16 > and 43). What's the advantage of replacing the command macros? I'm not opposed to it, but don't understand why. Especially given that the packaging guidelines use them: https://fedoraproject.org/wiki/Packaging:Perl > Tip: Drop line 53, it's unnecessary. Done. > Why are you excluding the cproton_perl.so from the package? Does it even > work without it?... That exclude seems to be a mistake, since cproton_perl.so still is there in the generated RPM. I've removed the exclude since it's no longer necessary. Updated SPEC: http://mcpierce.fedorapeople.org/rpms/perl-qpid_proton.spec Updated SRPM: http://mcpierce.fedorapeople.org/rpms/perl-qpid_proton-0.3-1.1.fc18.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4918012 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5sbXzCs5GF&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review