Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906245 --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> --- some fixes are needed 1) This BR is not needed: gcc-c++ See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 its already installed as minimal build environment 2) rpmlint complains about rpath See: https://fedoraproject.org/wiki/Packaging:Guidelines#Removing_Rpath marisa-tools.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/marisa-predictive-search ['/usr/lib64'] marisa-tools.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/marisa-lookup ['/usr/lib64'] marisa-tools.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/marisa-build ['/usr/lib64'] marisa-tools.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/marisa-reverse-lookup ['/usr/lib64'] marisa-tools.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/marisa-benchmark ['/usr/lib64'] marisa-tools.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/marisa-common-prefix-search ['/usr/lib64'] marisa-tools.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/marisa-dump ['/usr/lib64'] 3) Add docs/readme.en.html docs/style.css AUTHORS COPYING README as %docs to main package 4) if not building for EPEL then better drop cleaning of buildroot in %install 5) preserve timestamp as %make_install INSTALL="install -p" -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8TThOOruyw&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review