Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=887611 Mohamed El Morabity <pikachu.2014@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |pikachu.2014@xxxxxxxxx --- Comment #17 from Mohamed El Morabity <pikachu.2014@xxxxxxxxx> --- I'd be glad to review this package. I see also no problem to include this package in the official repositories. Some comments: - is there any reason you base your plugin on a git commit? Using the latest tag (Frodo_rc3 ) isn't OK? I've been using this tag for a moment with XBMC, with no particular issue. - vdr-devel provides many useful RPM macros (see /etc/rpm/macros.vdr) you should use instead of those you set on your .spec file: %{plugindir} --> %{vdr_plugindir} %{apiver} --> %{vdr_apiversion} %{configdir} --> %{vdr_configdir} - Is there a reason you add extra flags to %{optflags}? I can understand -fPIC is needed, but what about all the others? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=C44pJkx6lP&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review