Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=904843 --- Comment #7 from Al Stone <ahs3@xxxxxxxxxx> --- (In reply to comment #2) > Just few other comments. > > >NB: the intent would be for this package to supercede the iasl package which > >(a) only ships the iasl tool mentioned above from the same upstream source, > >and (b) is a little bit dated. This would be the more complete version of > >the ACPICA tools. > > - obsolete tag is needed: > http://fedoraproject.org/wiki/Packaging:Guidelines#Renaming. > 2FReplacing_Existing_Packages As noted elsewhere, there is an Obsoletes tag. Added a Provides tag to help clarify, too. > - I don't see any License file in the source archive. > https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/ > LicensingGuidelines#License_Text Added. Thanks for catching that! > - Where does tar.gz source come from ? > Because in https://www.acpica.org/downloads/ I see the 20130117 whereas the > 20130123 seems available in https://github.com/otcshare/acpica/. > > In this last case, you should look around > https://fedoraproject.org/wiki/Packaging:NamingGuidelines?rd=Packaging/ > NamingGuidelines#Snapshot_packages This is indeed a snapshot, so the version is now 20130123git, as I believe the policy is indicating it should be. Note that this is the only versioning that upstream uses on the code, unfortunately, so a version such as "1.0.20130123git" would not make a great deal of sense :(. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=muYQ3kCtwQ&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review