Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891873 --- Comment #3 from Mathieu Bridon <bochecha@xxxxxxxxxxxxxxxxx> --- (In reply to comment #2) > TODO: You can replace %{__perl} macro with plain perl. Fixed. > TODO: Build-require `perl(Exporter)' (lib/Net/IDN/Nameprep.pm:10). Fixed. > FIX: Build-require `perl(Unicode::Stringprep::Mapping)' > (lib/Net/IDN/Nameprep.pm:16). > FIX: Build-require `perl(Unicode::Stringprep::Prohibited)' > (lib/Net/IDN/Nameprep.pm:17). I added the requirements, but now I'm wondering: should they be versioned explicitly, like Unicode::Stringprep just above? (version >= 1.1 is required) After all, they are all modules from the same package. > FIX: Remove executable bit from Changes file. > FIX: Remove executable bit from Nameprep.pm. > FIX: Convert LICENSE and README to UTF-8. Fixed. > Please correct all `FIX' issues, obtain blessing from Fedora Legal > departments, consider fixing all `TODO' items, and provide new spec file. > Resolution: NOT approved. Those should all be fixed, here's the new submission. Spec URL: http://bochecha.fedorapeople.org/packages/perl-Net-IDN-Nameprep.spec SRPM URL: http://bochecha.fedorapeople.org/packages/perl-Net-IDN-Nameprep-1.101-2.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=l0sgFamJYC&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review