Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891873 --- Comment #2 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 are usable. Ok. Source file is original (SHA-256: 2861058143a8b26fb06b691ad289e3c6a0b0ae093f32769089f2a7c5fae4d4f8). Ok. Summary verified from lib/Net/IDN/Nameprep.pm. Ok. Description verified from lib/Net/IDN/Nameprep.pm. Ok. Licence of t/nameprep_vec.t is not (GPL+ or Artistic): # Copyright (C) The Internet Society (2003). All Rights Reserved. # # This document and translations of it may be copied and furnished # to others, and derivative works that comment on or otherwise # explain it or assist in its implementation may be prepared, # copied, published and distributed, in whole or in part, without # restriction of any kind, provided that the above copyright # notice and this paragraph are included on all such copies and # derivative works. However, this document itself may not be # modified in any way, such as by removing the copyright notice or # references to the Internet Society or other Internet # organizations, except as needed for the purpose of developing # Internet standards in which case the procedures for copyrights # defined in the Internet Standards process must be followed, or # as required to translate it into languages other than English. It's not included into binary package. So it does not affect License tag in spec file. However it forbids modifications. Actually I don't understand the text clearly: It allows derivative works, but it forbids modifying original document. This contradicts. Maybe the copyright holder wanted to forbid modification of the license text. But this way how it is written is ambiguous to me. Fedora cannot redistribute code which cannot be modified. FIX: Please ask <fedora-legal-list@xxxxxxxxxx> for clarification. No XS code included, noarch BuildArch is Ok. TODO: You can replace %{__perl} macro with plain perl. TODO: Build-require `perl(Exporter)' (lib/Net/IDN/Nameprep.pm:10). FIX: Build-require `perl(Unicode::Stringprep::Mapping)' (lib/Net/IDN/Nameprep.pm:16). FIX: Build-require `perl(Unicode::Stringprep::Prohibited)' (lib/Net/IDN/Nameprep.pm:17). All tests pass. Ok. $ rpmlint perl-Net-IDN-Nameprep.spec ../SRPMS/perl-Net-IDN-Nameprep-1.101-1.fc19.src.rpm ../RPMS/noarch/perl-Net-IDN-Nameprep-1.101-1.fc19.noarch.rpm perl-Net-IDN-Nameprep.src: W: spelling-error Summary(en_US) Stringprep -> String prep, String-prep, Stripping perl-Net-IDN-Nameprep.src: W: spelling-error %description -l en_US stringprep -> string prep, string-prep, stripping perl-Net-IDN-Nameprep.noarch: W: spelling-error Summary(en_US) Stringprep -> String prep, String-prep, Stripping perl-Net-IDN-Nameprep.noarch: W: spelling-error %description -l en_US stringprep -> string prep, string-prep, stripping perl-Net-IDN-Nameprep.noarch: W: spurious-executable-perm /usr/share/doc/perl-Net-IDN-Nameprep-1.101/Changes perl-Net-IDN-Nameprep.noarch: W: file-not-utf8 /usr/share/doc/perl-Net-IDN-Nameprep-1.101/README perl-Net-IDN-Nameprep.noarch: E: script-without-shebang /usr/share/perl5/vendor_perl/Net/IDN/Nameprep.pm perl-Net-IDN-Nameprep.noarch: W: file-not-utf8 /usr/share/doc/perl-Net-IDN-Nameprep-1.101/LICENSE 2 packages and 1 specfiles checked; 1 errors, 7 warnings. FIX: Remove executable bit from Changes file. FIX: Convert LICENSE and README to UTF-8. FIX: Remove executable bit from Nameprep.pm. $ rpm -q -lv -p ../RPMS/noarch/perl-Net-IDN-Nameprep-1.101-1.fc19.noarch.rpm drwxr-xr-x 2 root root 0 Jan 22 15:15 /usr/share/doc/perl-Net-IDN-Nameprep-1.101 -rwxr-xr-x 1 root root 1176 Dec 8 2011 /usr/share/doc/perl-Net-IDN-Nameprep-1.101/Changes -rw-r--r-- 1 root root 18407 Dec 8 2011 /usr/share/doc/perl-Net-IDN-Nameprep-1.101/LICENSE -rw-r--r-- 1 root root 769 Dec 8 2011 /usr/share/doc/perl-Net-IDN-Nameprep-1.101/README -rw-r--r-- 1 root root 2731 Jan 22 15:15 /usr/share/man/man3/Net::IDN::Nameprep.3pm.gz drwxr-xr-x 2 root root 0 Jan 22 15:15 /usr/share/perl5/vendor_perl/Net drwxr-xr-x 2 root root 0 Jan 22 15:15 /usr/share/perl5/vendor_perl/Net/IDN -rwxr-xr-x 1 root root 3004 Jan 22 15:15 /usr/share/perl5/vendor_perl/Net/IDN/Nameprep.pm FIX: Remove executable bit from /usr/share/doc/perl-Net-IDN-Nameprep-1.101/Changes and /usr/share/perl5/vendor_perl/Net/IDN/Nameprep.pm. $ rpm -q --requires -p ../RPMS/noarch/perl-Net-IDN-Nameprep-1.101-1.fc19.noarch.rpm | sort | uniq -c 1 perl(Exporter) 1 perl(:MODULE_COMPAT_5.16.2) 1 perl(strict) 1 perl(Unicode::Stringprep) >= 1.1 1 perl(Unicode::Stringprep::Mapping) 1 perl(Unicode::Stringprep::Prohibited) 1 perl(utf8) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Net-IDN-Nameprep-1.101-1.fc19.noarch.rpm | sort | uniq -c 1 perl(Net::IDN::Nameprep) = 1.101 1 perl-Net-IDN-Nameprep = 1.101-1.fc19 Binary provides are Ok. $ resolvedeps f19-build ../RPMS/noarch/perl-Net-IDN-Nameprep-1.101-1.fc19.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F19 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4893535). Ok. Otherwise the package is in line with Fedora and Packaging guidelines. Please correct all `FIX' issues, obtain blessing from Fedora Legal departments, consider fixing all `TODO' items, and provide new spec file. Resolution: NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0bpjBzT5If&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review