Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=889546 --- Comment #3 from Stanislav Ochotnicky <sochotni@xxxxxxxxxx> --- Package Review ============== Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed Issues: ======= - gtk-update-icon-cache is invoked when required Note: icons in ovirt-guest-agent-gdm-plugin See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache - post/postun scriptlets of kdm-plugin - noreplace on some things, just because user *can* break stuff by configuring something doesn't mean it should be forbidden. Especially the pam configuration. Most likely also /etc/security/ and dbus files. There are no simple reasons for admins to touch them, but if they do-> they obviously had their reasons. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [!]: %config files are marked noreplace or the reason is justified. Note: No (noreplace) in %config /etc/pam.d/ovirt-locksession %config /etc/pam.d/ovirt-shutdown %config /etc/pam.d/ovirt-hibernate %config %attr (644,root,root) /etc/udev/rules.d/55-ovirt-guest-agent.rules %config /etc/dbus-1/system.d/org.ovirt.vdsm.Credentials.conf %config /etc/security/console.apps/ovirt-locksession %config /etc/security/console.apps/ovirt-shutdown %config /etc/security/console.apps/ovirt-hibernate %config /etc/pam.d/gdm- ovirtcred %config /etc/pam.d/kdm-ovirtcred I'd prefer if this was discussed on packaging mailing list. From my POV, I'd say it should be possible that local administrator will want to modify security policies or pam settings and you should not overwrite his changes blindly on updates. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in ovirt- guest-agent-common , ovirt-guest-agent-pam-module , ovirt-guest-agent- gdm-plugin , ovirt-guest-agent-kdm-plugin [x]: Package complies to the Packaging Guidelines [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [-]: Large documentation must go in a -doc subpackage. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [?]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Scriptlets must be sane, if used. I *really* don't like post/postun of kdm-plugin subpackage. You are modifying configuration of another package. IMO that's road to hell. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: ovirt-guest-agent-common-1.0.6-2.fc19.noarch.rpm ovirt-guest-agent-pam-module-1.0.6-2.fc19.x86_64.rpm ovirt-guest-agent-gdm-plugin-1.0.6-2.fc19.x86_64.rpm ovirt-guest-agent-kdm-plugin-1.0.6-2.fc19.x86_64.rpm ovirt-guest-agent-common.noarch: W: only-non-binary-in-usr-lib ovirt-guest-agent-common.noarch: W: conffile-without-noreplace-flag /etc/pam.d/ovirt-locksession ovirt-guest-agent-common.noarch: W: conffile-without-noreplace-flag /etc/security/console.apps/ovirt-hibernate ovirt-guest-agent-common.noarch: W: conffile-without-noreplace-flag /etc/dbus-1/system.d/org.ovirt.vdsm.Credentials.conf ovirt-guest-agent-common.noarch: W: conffile-without-noreplace-flag /etc/pam.d/ovirt-shutdown ovirt-guest-agent-common.noarch: W: conffile-without-noreplace-flag /etc/udev/rules.d/55-ovirt-guest-agent.rules ovirt-guest-agent-common.noarch: W: conffile-without-noreplace-flag /etc/security/console.apps/ovirt-shutdown ovirt-guest-agent-common.noarch: W: conffile-without-noreplace-flag /etc/pam.d/ovirt-hibernate ovirt-guest-agent-common.noarch: W: conffile-without-noreplace-flag /etc/security/console.apps/ovirt-locksession ovirt-guest-agent-common.noarch: W: non-standard-uid /var/log/ovirt-guest-agent ovirtagent ovirt-guest-agent-common.noarch: W: non-standard-gid /var/log/ovirt-guest-agent ovirtagent ovirt-guest-agent-common.noarch: W: log-files-without-logrotate /var/log/ovirt-guest-agent ovirt-guest-agent-pam-module.x86_64: W: no-documentation ovirt-guest-agent-gdm-plugin.x86_64: W: conffile-without-noreplace-flag /etc/pam.d/gdm-ovirtcred ovirt-guest-agent-gdm-plugin.x86_64: W: no-documentation ovirt-guest-agent-kdm-plugin.x86_64: W: conffile-without-noreplace-flag /etc/pam.d/kdm-ovirtcred ovirt-guest-agent-kdm-plugin.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 17 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint ovirt-guest-agent-kdm-plugin ovirt-guest-agent-common ovirt-guest-agent-gdm-plugi n ovirt-guest-agent-pam-module ovirt-guest-agent-kdm-plugin.x86_64: W: conffile-without-noreplace-flag /etc/pam.d/kdm-ovirtcred ovirt-guest-agent-kdm-plugin.x86_64: W: no-documentation ovirt-guest-agent-common.noarch: W: only-non-binary-in-usr-lib ovirt-guest-agent-common.noarch: W: conffile-without-noreplace-flag /etc/pam.d/ovirt-locksession ovirt-guest-agent-common.noarch: W: conffile-without-noreplace-flag /etc/security/console.apps/ovirt-hibernate ovirt-guest-agent-common.noarch: W: conffile-without-noreplace-flag /etc/dbus-1/system.d/org.ovirt.vdsm.Credentials.conf ovirt-guest-agent-common.noarch: W: conffile-without-noreplace-flag /etc/pam.d/ovirt-shutdown ovirt-guest-agent-common.noarch: W: conffile-without-noreplace-flag /etc/udev/rules.d/55-ovirt-guest-agent.rules ovirt-guest-agent-common.noarch: W: conffile-without-noreplace-flag /etc/security/console.apps/ovirt-shutdown ovirt-guest-agent-common.noarch: W: conffile-without-noreplace-flag /etc/pam.d/ovirt-hibernate ovirt-guest-agent-common.noarch: W: conffile-without-noreplace-flag /etc/security/console.apps/ovirt-locksession ovirt-guest-agent-common.noarch: W: log-files-without-logrotate /var/log/ovirt-guest-agent ovirt-guest-agent-gdm-plugin.x86_64: W: conffile-without-noreplace-flag /etc/pam.d/gdm-ovirtcred ovirt-guest-agent-gdm-plugin.x86_64: W: no-documentation ovirt-guest-agent-pam-module.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 15 warnings. # echo 'rpmlint-done:' Requires -------- ovirt-guest-agent-kdm-plugin (rpmlib, GLIBC filtered): /bin/sh config(ovirt-guest-agent-kdm-plugin) kdm libQtCore.so.4()(64bit) libQtDBus.so.4()(64bit) libQtGui.so.4()(64bit) libQtSvg.so.4()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libkdecore.so.5()(64bit) libkdeui.so.5()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) ovirt-guest-agent ovirt-guest-agent-pam-module rtld(GNU_HASH) ovirt-guest-agent-common (rpmlib, GLIBC filtered): /bin/sh config(ovirt-guest-agent-common) dbus-python kernel python-ethtool rpm-python udev usermode ovirt-guest-agent-gdm-plugin (rpmlib, GLIBC filtered): config(ovirt-guest-agent-gdm-plugin) gdm libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libcairo.so.2()(64bit) libdbus-1.so.3()(64bit) libdbus-glib-1.so.2()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libgdk-x11-2.0.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgdmsimplegreeter.so.1()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-x11-2.0.so.0()(64bit) libm.so.6()(64bit) libpam.so.0()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpangoft2-1.0.so.0()(64bit) ovirt-guest-agent ovirt-guest-agent-pam-module rtld(GNU_HASH) ovirt-guest-agent-pam-module (rpmlib, GLIBC filtered): libc.so.6()(64bit) libpam.so.0()(64bit) libpam.so.0(LIBPAM_1.0)(64bit) ovirt-guest-agent pam rtld(GNU_HASH) Provides -------- ovirt-guest-agent-kdm-plugin: config(ovirt-guest-agent-kdm-plugin) kgreet_ovirtcred.so()(64bit) ovirt-guest-agent-kdm-plugin ovirt-guest-agent-kdm-plugin(x86-64) ovirt-guest-agent-common: config(ovirt-guest-agent-common) ovirt-guest-agent ovirt-guest-agent-common ovirt-guest-agent-gdm-plugin: config(ovirt-guest-agent-gdm-plugin) libovirtcred.so()(64bit) ovirt-guest-agent-gdm-plugin ovirt-guest-agent-gdm-plugin(x86-64) ovirt-guest-agent-pam-module: ovirt-guest-agent-pam-module ovirt-guest-agent-pam-module(x86-64) pam_ovirt_cred.so()(64bit) Unversioned so-files -------------------- ovirt-guest-agent-pam-module: /lib64/security/pam_ovirt_cred.so ovirt-guest-agent-gdm-plugin: /usr/lib64/gdm/simple-greeter/extensions/libovirtcred.so ovirt-guest-agent-kdm-plugin: /usr/lib64/kde4/kgreet_ovirtcred.so MD5-sum check ------------- http://resources.ovirt.org/releases/3.2/src/ovirt-guest-agent-1.0.6.tar.bz2 : CHECKSUM(SHA256) this package : ab801cbee7b89251814988843b40dde65c40fc93554ceca9261889b2084f1c22 CHECKSUM(SHA256) upstream package : ab801cbee7b89251814988843b40dde65c40fc93554ceca9261889b2084f1c22 Generated by fedora-review 0.3.1 (903b443) last change: 2012-12-20 Buildroot used: fedora-raw-x86_64 Command line :/home/w0rm/work/projects/fedora-review/try-fedora-review -b 889546 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=z8m90XO3GX&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review