Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901387 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 are useful. Ok. Source file is original (SHA-256: c771fd9e46d16f2a38901afc1252445d8b586308e4da35dd88983b675b23afa4). Ok. Summary verified from (Affixes.pm). Ok. Description verified from (Affixes.pm). Ok. License verified from (Affixes.pm). Ok. No XS code, noarch BuildArch is Ok. TODO: You can replace %{__perl} macro with plain perl command. TODO: Replace PERL_INSTALL_ROOT variable with DESTDIR in %install section. Current ExtUtils::MakeMaker understands DESTDIR. TODO: Build-require `perl(Exporter)' (Affixes.pm:7). TODO: Build-require `perl(AutoLoader)' (Affixes.pm:8). TODO: Specify version constrain `>= 1.14' at perl(Test::Pod) (t/pod.t:4). TODO: Specify version constrain `>= 1.04' at perl(Test::Pod::Coverage) (t/pod-coverage.t:4). All test pass. Ok. $ rpmlint perl-Text-Affixes.spec ../SRPMS/perl-Text-Affixes-0.07-1.fc19.src.rpm ../RPMS/noarch/perl-Text-Affixes-0.07-1.fc19.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Text-Affixes-0.07-1.fc19.noarch.rpm drwxr-xr-x 2 root root 0 Jan 21 17:59 /usr/share/doc/perl-Text-Affixes-0.07 -rw-r--r-- 1 root root 921 Nov 19 2005 /usr/share/doc/perl-Text-Affixes-0.07/Changes -rw-r--r-- 1 root root 3664 Nov 19 2005 /usr/share/doc/perl-Text-Affixes-0.07/README -rw-r--r-- 1 root root 3155 Jan 21 17:59 /usr/share/man/man3/Text::Affixes.3pm.gz drwxr-xr-x 2 root root 0 Jan 21 17:59 /usr/share/perl5/vendor_perl/Text -rw-r--r-- 1 root root 5165 Nov 19 2005 /usr/share/perl5/vendor_perl/Text/Affixes.pm drwxr-xr-x 2 root root 0 Jan 21 17:59 /usr/share/perl5/vendor_perl/auto/Text drwxr-xr-x 2 root root 0 Jan 21 17:59 /usr/share/perl5/vendor_perl/auto/Text/Affixes -rw-r--r-- 1 root root 91 Jan 21 17:59 /usr/share/perl5/vendor_perl/auto/Text/Affixes/autosplit.ix File layout and permissions are Ok. (I'm not convinced the AutoLoad stuff is needed, but that's upstream problem.) $ rpm -q --requires -p ../RPMS/noarch/perl-Text-Affixes-0.07-1.fc19.noarch.rpm | sort |uniq -c 1 perl >= 0:5.006 1 perl(AutoLoader) 1 perl(Exporter) 1 perl(:MODULE_COMPAT_5.16.2) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Text-Affixes-0.07-1.fc19.noarch.rpm | sort |uniq -c 1 perl(Text::Affixes) = 0.07 1 perl-Text-Affixes = 0.07-1.fc19 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Text-Affixes-0.07-1.fc19.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F19 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4890237). Ok. Package is in line with Fedora and Perl packaging guidelines. Please consider fixing `TODO' items before building this package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=GQWEo6GtYm&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review