[Bug 889505] Review Request: libkqueue - A userspace implementation of the kqueue kernel event notification mechanism

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=889505

--- Comment #13 from Eric Radman <eradman@xxxxxxxxxxxxxxx> ---
> --- Comment #12 from Michael Schwendt <mschwendt@xxxxxxxxx> ---
> Note that I haven't reviewed the latest update except that it still doesn't
> use the global CFLAGS, but overrides them with own ones.

Indeed this is always bad behavior, the following change to config.inc
corrects this

cflags="$cflags -fpic"
ldflags="$ldflags"

> > I understand that the Fedora project does not want applications to be
> > built with static libraries, but it didn't occur to me that users
> > are not permitted to build their own utilities using cc -static.
> 
> The same users, who would simply install an own special build of libkqueue
> into /usr/local then? ;)

True! Making this point up front would avoid a lot of confusion. None of
the arguments I've read so far put it so simply.

> why use %{_configure} and not just ./configure? The macro doesn't add any
> value, does it? You're free to keep using it, I'm just curious.
> Not that you think you must use it or such.

Only because someone bothered to define the macro, I assume for some
good reason. Other than that it's a mystery to me.

> > The only exception is LIBDIR which is set to $DESTDIR/usr/lib instead
> > of $DESTDIR/usr/lib64. I'm not sure how to improve this.
> 
> What about passing --libdir=%{_libdir} to the configure script? The script
> seems to handle that. As pointed out before, the wrong /usr/lib gets
> substituted into the built files. libkqueue.pc for example.

That worked perfectly, thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=u0m71oxpUd&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]