Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=889505 --- Comment #12 from Michael Schwendt <mschwendt@xxxxxxxxx> --- Note that I haven't reviewed the latest update except that it still doesn't use the global CFLAGS, but overrides them with own ones. Just some answers: > I understand that the Fedora project does not want applications to be > built with static libraries, but it didn't occur to me that users > are not permitted to build their own utilities using cc -static. The same users, who would simply install an own special build of libkqueue into /usr/local then? ;) I don't intend to argue a lot about this. It's just that the packaging guidelines say | In general, packagers are strongly encouraged not to ship static libs | unless a compelling reason exists. and actually most libraries are not shipped as static builds, because neither the packager nor the developer would find a _compelling_ reason why to insist on shipping the static build. Libtool archives (.la files) are a different matter, and shipping them in the -static subpackage would have been wrong, btw, since they are not specific to static linking. > > %{_configure} --prefix=%{_prefix} > %{configure} breaks the build by setting --target Yes, that's why I suggested mentioning the rationale in the spec file. Which is what you've done in the latest update. Good. The real question was why use %{_configure} and not just ./configure? The macro doesn't add any value, does it? You're free to keep using it, I'm just curious. Not that you think you must use it or such. > The only exception is LIBDIR which is set to $DESTDIR/usr/lib instead > of $DESTDIR/usr/lib64. I'm not sure how to improve this. What about passing --libdir=%{_libdir} to the configure script? The script seems to handle that. As pointed out before, the wrong /usr/lib gets substituted into the built files. libkqueue.pc for example. > Is the right way to do it? > > %dir %{_includedir}/kqueue > %dir %{_includedir}/kqueue/sys Yes, for this package, yes. For other packages and where you want to include entire directory trees, there are other solutions mentioned in the guidelines. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9Ejh3tZq8G&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review