Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=872966 --- Comment #13 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> --- Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4871939 $ rpmlint -i -v * spacefm.src: I: checking spacefm.src: W: spelling-error %description -l en_US multi -> mulch, mufti The value of this tag appears to be misspelled. Please double-check. spacefm.src: W: spelling-error %description -l en_US udev -> dude The value of this tag appears to be misspelled. Please double-check. spacefm.src: W: spelling-error %description -l en_US customizable -> customization The value of this tag appears to be misspelled. Please double-check. spacefm.src: I: checking-url http://ignorantguru.github.com/spacefm/ (timeout 10 seconds) spacefm.src: I: checking-url http://downloads.sourceforge.net/spacefm/spacefm-0.8.4.tar.xz (timeout 10 seconds) spacefm.i686: I: checking spacefm.i686: W: spelling-error %description -l en_US multi -> mulch, mufti The value of this tag appears to be misspelled. Please double-check. spacefm.i686: W: spelling-error %description -l en_US udev -> dude The value of this tag appears to be misspelled. Please double-check. spacefm.i686: W: spelling-error %description -l en_US customizable -> customization The value of this tag appears to be misspelled. Please double-check. spacefm.i686: I: checking-url http://ignorantguru.github.com/spacefm/ (timeout 10 seconds) spacefm.i686: W: no-manual-page-for-binary spacefm-auth Each executable in standard binary directories should have a man page. spacefm.i686: W: no-manual-page-for-binary spacefm Each executable in standard binary directories should have a man page. spacefm.x86_64: I: checking spacefm.x86_64: W: spelling-error %description -l en_US multi -> mulch, mufti The value of this tag appears to be misspelled. Please double-check. spacefm.x86_64: W: spelling-error %description -l en_US udev -> dude The value of this tag appears to be misspelled. Please double-check. spacefm.x86_64: W: spelling-error %description -l en_US customizable -> customization The value of this tag appears to be misspelled. Please double-check. spacefm.x86_64: I: checking-url http://ignorantguru.github.com/spacefm/ (timeout 10 seconds) spacefm.x86_64: W: no-manual-page-for-binary spacefm-auth Each executable in standard binary directories should have a man page. spacefm.x86_64: W: no-manual-page-for-binary spacefm Each executable in standard binary directories should have a man page. spacefm-debuginfo.i686: I: checking spacefm-debuginfo.i686: I: checking-url http://ignorantguru.github.com/spacefm/ (timeout 10 seconds) spacefm-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/spacefm-0.8.4/src/desktop/working-area.c The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. spacefm-debuginfo.i686: W: spurious-executable-perm /usr/src/debug/spacefm-0.8.4/src/settings.c The file is installed with executable permissions, but was identified as one that probably should not be executable. Verify if the executable bits are desired, and remove if not. spacefm-debuginfo.x86_64: I: checking spacefm-debuginfo.x86_64: I: checking-url http://ignorantguru.github.com/spacefm/ (timeout 10 seconds) spacefm-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/spacefm-0.8.4/src/desktop/working-area.c The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. spacefm-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/spacefm-0.8.4/src/settings.c The file is installed with executable permissions, but was identified as one that probably should not be executable. Verify if the executable bits are desired, and remove if not. spacefm.spec: I: checking-url http://downloads.sourceforge.net/spacefm/spacefm-0.8.4.tar.xz (timeout 10 seconds) 5 packages and 1 specfiles checked; 2 errors, 15 warnings. Most of the rpmlint messages are ignorable. But the file src/settings.c is executable, which is unneeded. Well, it doesn't land in the binary package, but it could cause undesired reactions if someone installs the debug package. You should remove the executable bit before building the binary (in the %prep section). Moreover, the package uses the folder %{_datadir}/icons/Faenza/apps/48/ but doesn't own. It is already owned by the package faenza-icon-theme. But imagine, someone doesn't like the Faenza icons and doesn't want to install an extra package. That's why I recommend to split out the Faenza icons into a subpackage which requires both spacefm and faenza-icon-theme. %doc %{_datadir}/doc/spacefm It is somewhat strange to have two doc folders. The first one (versioned) contains the usual stuff such as COPYING etc. and the second one contains the html files. Would be nice to have both in the versioned folder, if possible. Is there a way from the spacefm gui to open the html files? Or are they stand-alone? Perhaps spacefm has a configure switch to define the folder for the help files. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=q6poo0W91W&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review