Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=891240 Miro Hrončok <mhroncok@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #4 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- > SRPM: http://patches.fedorapeople.org/npm/nodejs-which-1.0.5-3.fc17.src.rpm You've provided the old link. Using http://patches.fedorapeople.org/npm/nodejs-which-1.0.5-4.fc17.src.rpm $ rpmlint ../SRPMS/nodejs-which-1.0.5-4.fc18.src.rpm ../RPMS/noarch/nodejs-which-1.0.5-4.fc18.noarch.rpm nodejs-which.noarch: W: only-non-binary-in-usr-lib nodejs-which.noarch: W: dangling-relative-symlink /usr/bin/which-nodejs ../lib/node_modules/bin/which nodejs-which.noarch: W: no-manual-page-for-binary which-nodejs 2 packages and 0 specfiles checked; 0 errors, 3 warnings. > FIX: Bad symlink: /usr/bin/which.nodejs ../node_modules/bin/which Corrected. $ rpm -q -lv -p ../RPMS/noarch/nodejs-which-1.0.5-4.fc18.noarch.rpm lrwxrwxrwx 1 root root 29 led 15 20:48 /usr/bin/which-nodejs -> ../lib/node_modules/bin/which drwxr-xr-x 2 root root 0 led 15 20:48 /usr/lib/node_modules/which drwxr-xr-x 2 root root 0 bře 2 2012 /usr/lib/node_modules/which/bin -rwxr-xr-x 1 root root 289 srp 7 2011 /usr/lib/node_modules/which/bin/which drwxr-xr-x 2 root root 0 led 15 20:48 /usr/lib/node_modules/which/node_modules -rw-r--r-- 1 root root 435 bře 2 2012 /usr/lib/node_modules/which/package.json -rw-r--r-- 1 root root 3002 bře 2 2012 /usr/lib/node_modules/which/which.js drwxr-xr-x 2 root root 0 led 15 20:48 /usr/share/doc/nodejs-which-1.0.5 -rw-r--r-- 1 root root 1092 zář 23 2011 /usr/share/doc/nodejs-which-1.0.5/LICENSE -rw-r--r-- 1 root root 199 srp 7 2011 /usr/share/doc/nodejs-which-1.0.5/README.md > FIX: There is no /usr/lib/node_modules/which/bin/which ! Corrected. > Is the which.nodejs filename somehow documented, or you've made it up? Wouldn't which-nodejs or nodejs-which be better? Changed to which-nodejs. Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5zRNvsY8gA&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review