Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: coreutils https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225655 ------- Additional Comments From pertusus@xxxxxxx 2007-02-21 18:20 EST ------- (In reply to comment #16) > > > Depending on itself: Er.. can you be more specific? > > The build is depending on coreutils commands, like mkdir > > Are we talking about BuildRequires tags or Requires tags? Please be specific > with the changes you'd like me to make -- also it would help if you number them. :-) I am talking about BuildRequires, and I don't really want that you do changes, since it seems impossible to me to remove those bootstrapping issues. But I'd like something like your opinion on that subject. > > There is still one /usr/bin: > > for i in env cut; do ln -sf ../../bin/$i $RPM_BUILD_ROOT/usr/bin; done > > Take a look at the wider picture there: we are making compatibility symlinks for > binaries that used to be in /usr/bin but are now in /bin. We explicitly know > from the history of the packages where these binaries used to be. Changing a > variable is not going to change that. Changing /usr/bin here to be %{_bindir} > would be incorrect. I wouldn't say incorrect, but not using a macro seems correct. A suggestions: use the install-info scriptlets from the guidelines, they are simpler. So replace, in %preun [ -f %{_infodir}/%{name}.info.gz ] && \ /sbin/install-info --delete %{_infodir}/%{name}.info* \ %{_infodir}/dir || : with /sbin/install-info --delete %{_infodir}/%{name}.info %{_infodir}/dir || : and, in %post [ -f %{_infodir}/%{name}.info* ] && \ /sbin/install-info %{_infodir}/%{name}.info* %{_infodir}/dir || : with /sbin/install-info %{_infodir}/%{name}.info %{_infodir}/dir || : I find it very strange to use perl to do simple substitutions when a sed call does exactly the same. I don't have any other remark. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review