Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: coreutils https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225655 ------- Additional Comments From twaugh@xxxxxxxxxx 2007-02-20 06:31 EST ------- > > > Requires(post): grep, /sbin/install-info, coreutils > > > I am not sure that coreutils in Requires(post) makes sense... > > Depending on itself: Er.. can you be more specific? > The build is depending on coreutils commands, like mkdir Are we talking about BuildRequires tags or Requires tags? Please be specific with the changes you'd like me to make -- also it would help if you number them. :-) > There is still one /usr/bin: > for i in env cut; do ln -sf ../../bin/$i $RPM_BUILD_ROOT/usr/bin; done Take a look at the wider picture there: we are making compatibility symlinks for binaries that used to be in /usr/bin but are now in /bin. We explicitly know from the history of the packages where these binaries used to be. Changing a variable is not going to change that. Changing /usr/bin here to be %{_bindir} would be incorrect. > remove / in RPM_BUILD_ROOT/%{_datadir} Fixed. > Also I don't think that /etc/profile.d/ content should be > (noreplace) and I even think that making it %(config) is dubious. Fixed. Tagged and built as 6.7-8.fc7. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review