Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=883472 --- Comment #2 from Radek Pazdera <rpazdera@xxxxxxxxxx> --- (In reply to comment #1) > > # Turn off the brp-python-bytecompile script > > %global __os_install_post %(echo '%{__os_install_post}' | > > sed -e 's!/usr/lib[^[:space:]]*/brp-python-bytecompile[[:space:]].*$!!g') > > As package spec files are like source code, it would be good to add the > comment _why_ you turn off the byte-compilation. You do explain that in the > review request, but not in the spec file. You're right, it should be explained in the spec file as well. I added the comment. > > Requires: python2 >= 2.6 > > Such an explicit dependency doesn't work well, since there is an automatic > dependency on a specific python(abi) version. This explicit one would be > inaccurate and superfluous. > > http://fedoraproject.org/wiki/Packaging:Python Oh, I'm sorry, I must have missed that. I changed it to require python2 only. > > BuildRequires: python2-devel >= 2.6, python3-devel, systemd-units > > Both Python versions? The spec file doesn't handle that. I had to include python3-devel for the py_byte_compile macro. It is not used anything else. I might have missed here something too. Is there any way to get the macro without the necessity to require python3-devel? > These cause several "unowned" directories: > https://fedoraproject.org/wiki/Packaging:UnownedDirectories > > > %{_mandir}/man1/%{name}-ctl.1.gz > > %{_mandir}/man1/%{name}-slave.1.gz > > Many reviewers here point out that it may be more future-proof/versatile to > use a wildcard to allow for a changed/reconfigured compression technique: I fixed these as well. Thank you very much for your comments! I really appreciate your help. I fixed them and will repost the updated spec and srcrpm shortly. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Xsh81IycjF&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review