Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=883472 --- Comment #1 from Michael Schwendt <mschwendt@xxxxxxxxx> --- Not a full review, just some comments: > # Turn off the brp-python-bytecompile script > %global __os_install_post %(echo '%{__os_install_post}' | > sed -e 's!/usr/lib[^[:space:]]*/brp-python-bytecompile[[:space:]].*$!!g') As package spec files are like source code, it would be good to add the comment _why_ you turn off the byte-compilation. You do explain that in the review request, but not in the spec file. > Requires: python2 >= 2.6 Such an explicit dependency doesn't work well, since there is an automatic dependency on a specific python(abi) version. This explicit one would be inaccurate and superfluous. http://fedoraproject.org/wiki/Packaging:Python > BuildRequires: python2-devel >= 2.6, python3-devel, systemd-units Both Python versions? The spec file doesn't handle that. > %{python_sitelib}/%{name}/__init__.* > %{python_sitelib}/%{name}/Common/* > %{python_sitelib}/%{name}/Controller/* > %{_datadir}/%{name}/* > %{python_sitelib}/%{name}/Slave/* These cause several "unowned" directories: https://fedoraproject.org/wiki/Packaging:UnownedDirectories /bin/rpmls is very convenient for listing package contents (and an alternative to rpm -qlv …). > %{_mandir}/man1/%{name}-ctl.1.gz > %{_mandir}/man1/%{name}-slave.1.gz Many reviewers here point out that it may be more future-proof/versatile to use a wildcard to allow for a changed/reconfigured compression technique: %{_mandir}/man1/%{name}-ctl.1.* %{_mandir}/man1/%{name}-slave.1.* -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Dn6ZLYew3V&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review