Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=887913 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends On| |876405, 876399 --- Comment #5 from Petr Pisar <ppisar@xxxxxxxxxx> --- This is rebase, restarting review: URL and Source0 are usable. Ok Source tar ball is original (SHA-256: 3bf01327a002852504026b673449d9c8e2a77543567d42d206aa7f6156b181de). Ok. perl-Math-Clipper-1.16-1.no-c-sources.patch is good. Ok. Summary is good. Ok. Description is good. Ok. License verified from lib/Math/Clipper.pm. Ok. Bundled Clipper is not used. Ok. TODO: Do not package META.json and xsp subtree. These are not useful for users. TODO: Specify version for perl(Module::Build::WithXSpp) build-require `>= 0.10' (META.yml:12). TODO: In my opinion `perl(ExtUtils::XSpp)' is not direct dependency of this package, so it shouldn't be build-required. TODO: Build-require `perl(XSLoader)' for running tests (lib/Math/Clipper.pm:14). TODO: Build-require `perl(constant)' for running tests (t/002basic.t:6). FIX: This package build-requires Module::Build::WithXSpp (bug #876405) and ExtUtils::Typemaps::Default (bug #876399) which are not yet in Fedora. I added proper bug dependencies and I postponed this review until they get into Fedora. Resolution: POSTPONED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DTKmEyntXu&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review