[Bug 890859] Review Request: scopy - Application to play to Italian card game Scopa

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=890859

--- Comment #6 from Antonio Trande <trpost@xxxxxxxxxxxx> ---
(In reply to comment #5)
> Only a few questions raised by the spec file, since I'm short on time:
> 
> 
> > # Turn off the brp-python-bytecompile script
> 
> _Why_ is it turnt off?
> 
> 
> > %global __python %{__python3}
> 
> > BuildRequires: python2-devel 
> > BuildRequires: python3-devel
> 
> Both?
> 
>   $ rpm --query --Requires scopy|grep py
>   /usr/bin/python
> 
> That would be Python 2.
> On the contrary:
> 
>   $ cat /usr/bin/scopy 
>   #!/bin/bash
>   cd /usr/share/scopy/src
>   env python scopy.py
> 
> That would be like "#! /usr/bin/env python", which is discouraged. Have
> found only this:
> 
> http://fedoraproject.org/wiki/Script_Interpreters_%28draft%29
> http://fedoraproject.org/wiki/Packaging:Python
> 
> 
> > # Manually invoke the python byte compile macro for file that needs byte
> > # compilation.
> 
> Why?
> 
> > %py_byte_compile %{__python3} $RPM_BUILD_ROOT%{_datadir}/src/Actions/Multiplayer.py
> 
> That gives an error in the build.log. The path is wrong. %name is missing.

Hi Michael.

Probably I have badly comprehended
http://fedoraproject.org/wiki/Packaging:Python#Bytecompiling_with_the_correct_python_version

or the error appears.

This is the error that leads me to do use python byte compile macro:

+ /usr/lib/rpm/brp-python-bytecompile /usr/bin/python 1
Bytecompiling .py files below
/home/sagitter/rpmbuild/BUILDROOT/scopy-0.4.2-2.fc18.x86_64/usr/lib/python2.7/
using /usr/bin/python2.7
Compiling
/home/sagitter/rpmbuild/BUILDROOT/scopy-0.4.2-2.fc18.x86_64/usr/share/scopy/src/Actions/Multiplayer.py
...
Sorry: IndentationError: ('unindent does not match any outer indentation
level', ('/usr/share/scopy/src/Actions/Multiplayer.py', 90, 27, '\tdef
crea_win_multi(self):\n'))

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=oiBFehB3q5&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]