Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890859 --- Comment #5 from Michael Schwendt <mschwendt@xxxxxxxxx> --- Only a few questions raised by the spec file, since I'm short on time: > # Turn off the brp-python-bytecompile script _Why_ is it turnt off? > %global __python %{__python3} > BuildRequires: python2-devel > BuildRequires: python3-devel Both? $ rpm --query --Requires scopy|grep py /usr/bin/python That would be Python 2. On the contrary: $ cat /usr/bin/scopy #!/bin/bash cd /usr/share/scopy/src env python scopy.py That would be like "#! /usr/bin/env python", which is discouraged. Have found only this: http://fedoraproject.org/wiki/Script_Interpreters_%28draft%29 http://fedoraproject.org/wiki/Packaging:Python > # Manually invoke the python byte compile macro for file that needs byte > # compilation. Why? > %py_byte_compile %{__python3} $RPM_BUILD_ROOT%{_datadir}/src/Actions/Multiplayer.py That gives an error in the build.log. The path is wrong. %name is missing. > desktop-file-edit \ > --remove-category=Game \ > ${RPM_BUILD_ROOT}%{_datadir}/applications/%{name}.desktop > > desktop-file-edit \ > --add-category="Game;" \ > ${RPM_BUILD_ROOT}%{_datadir}/applications/%{name}.desktop desktop-file-edit fixes a missing ';' automatically when you use it to edit a .desktop file. It warns about that. And if you remove/add the category explicitly, it would also append/insert a needed ';' automatically. It's possible to execute it once with multiple edit options. > Requires: gtk3 Probably, but there are gtk2 files included, too. No idea yet how that all fits together. Similarly confusing (albeit entirely harmless): $ rpmls scopy|grep build drwxr-xr-x /usr/share/scopy/build drwxr-xr-x /usr/share/scopy/build/scripts-3.3 -rwxr-xr-x /usr/share/scopy/build/scripts-3.3/scopy $ cat /usr/share/scopy/build/scripts-3.3/scopy #!/bin/bash cd /usr/share/scopy/src env python scopy.py -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NrllTJNzb3&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review