Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=890491 Trond H. Amundsen <t.h.amundsen@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |t.h.amundsen@xxxxxxxxxxx --- Comment #1 from Trond H. Amundsen <t.h.amundsen@xxxxxxxxxxx> --- Not an official review, I just have some comments on the spec file: * These are only needed if rpmbuild doesn't find those dependencies automatically: Requires: perl(LockFile::Simple) Requires: perl(Mail::Internet) Requires: perl(Test::More) * Unless EPEL5 is one of the intended targets you can (and should) omit the BuildRoot and the whole %clean section * The description is weird... "I wanted something etc." should be rephrased * You don't need a macro for %{__perl} (I think). I'm not 100% sure of this one. * Spec files don't belong in %doc, at least not spec files for other packages * You should use %perl_default_filter, see URL: https://fedoraproject.org/wiki/Perl_default_filter -trond -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0qckzRArXH&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review