Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=878243 --- Comment #8 from Vít Ondruch <vondruch@xxxxxxxxxx> --- (In reply to comment #4) > Requires: ruby - removed (I'll have to start doing that from now on) I am negative about this change: $ grep "Requires: *ruby$" rubygem-compass-rails.spec Requires: ruby > Test Suite: > I didn't notice that it had bypassed all the tests and returned with a > positive outcome. I wish it wouldn't do that. > I tried with minitest, building and installing all the dependancies (compass > > 0.12, and rainbow), and after all that, it didn't run any tests either. Hm, the test suite is insane :/ It looks more like test suite of Bundler then test suite of simple gem. ATM, I would suggest you to disable the test suite including all the BR and if you don't mind, please ask the upstream if it is possible to run the test suite with limited usage of bundler and just against Rails 3.2 and document the situation in .spec file. BTW it would be better to run the test suite in .%{gem_instdir} if it will be possible one day in the future. And I have on last minor nit: * Keep the %{gem_instdir}/gemfiles - I would keep this files in -doc subpackage. Upstream distributes them, so let's keep them Otherwise, the package looks good => APPROVED. Please fix the above mentioned issue prior importing package into Fedora. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RlPl0PeU3S&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review