[Bug 875150] Review Request: MariaDB - An enhanced drop-in replacement for MySQL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=875150

--- Comment #12 from Renich Bon Ciric <renich@xxxxxxxxxxxxxxxx> ---
(In reply to comment #11)
> Sorry for quite long delay, but I've finally found time to get back to this.
> However, after consulting with another packagers it seems much better to not
> use completely new SPEC file and packaging mariadb from scratch, but we
> should rather work on existing mysql.spec instead. There are several reasons:
> 
> 1. there are many things we really need in mariadb.spec and that are already
> in mysql.spec (like test suite run, proper build requires, ...)
> 2. admins will probably better accept a new package if it's as much similar
> as the previous one
> 3. patches - most of them are still valid even for mariadb source (but I got
> rid of some)
> 
> So I've done changes in mysql.spec and converted it to mariadb.spec, which
> is available here together with SRPM:
> 
> Spec URL: http://hhorak.fedorapeople.org/mariadb-review/mariadb.spec
> SRPM URL:
> http://hhorak.fedorapeople.org/mariadb-review/mariadb-5.5.28a-4.fc18.src.rpm
> 
> No all tests pass during the build currently, so the test build doesn't
> break if test suite fails. What is important, the tests suite works fine
> after install, so the failing tests are only build-time problem.

I understand. If I recall correctly, I suggested this approach in the
beginning. Anyway, it seems like a good idea.

> Anyway, I'm currently assigned as a reviewer, but I'd rather take over the
> packaging work, if you don't mind, Renich. Then I'd need someone else to do
> the package review actually, since it wouldn't be good to do the review on
> own work.
> 
> So we can simply switch the roles (which means you would be the reviewer) or
> I can ask someone else to do that, in case you're not feeling comfortable
> with that. What do you think?

Well, I am glad to let you be the packager. The goal is to have MariaDB in
Fedora. Let me know if I can assist you.

On the reviewer offer, It'd be my first package as a reviewer and I don't feel
it's a good one to start with; I rather start with a simpler one.

I will kindly refuse. Please, find another reviewer.

Thank you for your hard work and effort.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fp0mWr3JAL&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]