Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=888301 --- Comment #9 from Mario Ceresa <mrceresa@xxxxxxxxx> --- Oops mid-air collision!! :) Hi again, some miscellaneous findings before a more through review: * There are at least two licenses: MIT (OrthancCppClient) and GPLv3. This should be reflected in the SPEC file as in: https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#Multiple_Licensing_Scenarios * Core/SQlite contains an sqlite wrapper from chrome. Is it under BSD license. I see there are some modifications specifically made for Orthanc, which could qualify as a fork. Sebastian, in order to understand if this is the case, would you mind to comment (briefly) on these questions (https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries#Standard_questions)? * No need to bundle jsoncpp, it is currently in review here: https://bugzilla.redhat.com/show_bug.cgi?id=882617 * I see a lot of cmake files that deal with 3rd part libraries. If you don't use them, why don't you "rm -rf" them in the %prep section? Just to be sure we are not using them? Please comment on these issues and I'll continue with the review. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NK75PZh3KT&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review